New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bits and pieces #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only the main package was pinnned, which can lead to unexpected behaviour if one of the dependencies of those packages change.
TrueBrain
force-pushed
the
minor_cleanup
branch
from
April 15, 2020 14:58
176d1f0
to
a39f0a2
Compare
frosch123
reviewed
Apr 15, 2020
I am not sure how the configuration will look like, but now the config variables are split over two files. |
This makes the coding-style consistent, and removes the "emotion" from coding-style.
TrueBrain
force-pushed
the
minor_cleanup
branch
from
April 15, 2020 17:02
d9b5a38
to
4503aba
Compare
frosch123
previously approved these changes
Apr 15, 2020
This makes it a bit easier to understand what belongs where, and makes a bit easier to see what happens in main.py.
We are not paid per letter, so we can handle this :D
TrueBrain
force-pushed
the
minor_cleanup
branch
from
April 15, 2020 17:47
4503aba
to
14472e0
Compare
TrueBrain
force-pushed
the
minor_cleanup
branch
from
April 15, 2020 17:58
14472e0
to
5f6236d
Compare
frosch123
reviewed
Apr 15, 2020
TrueBrain
force-pushed
the
minor_cleanup
branch
from
April 15, 2020 18:06
5f6236d
to
71203f3
Compare
… other options Flask comes with click built-in, so it needs a tiny bit of wrapping to make useful.
TrueBrain
force-pushed
the
minor_cleanup
branch
from
April 15, 2020 18:08
71203f3
to
95a8780
Compare
frosch123
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some bits and pieces to bring this repository on-par with the other Python repositories we have. Mostly moving around of code. This PR introduces no functional change what-so-ever.