nixos/rss2email: move from /var to /var/lib #85317
Conversation
This way, we can use StateDirectory instead of a tmpfile rule.
|
This looks good :) that said… it means that it's not possible to move back from |
|
I think @aanderse had some plans on moving more state to native |
| ]; | ||
| system.activationScripts.rss2email = lib.stringAfter [ "users" ] '' | ||
| if [ -e /var/rss2email -a ! -e /var/lib/rss2email ]; then | ||
| mv /var/rss2email /var/lib/rss2email |
There was a problem hiding this comment.
I suppose this script can be optionally included depending on state version?
The tmpfiles rules line above needs to be changed to /var/lib/rss2mail because new users won't have this directory yet.
There was a problem hiding this comment.
Yeah, this should be an optionalString and gated on stateVersion. I'd prefer having it inside preStart too.
|
Jörg Thalheim <notifications@github.com> writes:
The tmpfiles rules line above needs to be changed to
`/var/lib/rss2mail` because new users won't have this directory yet.
Won't systemd create it from StateDirectory?
|
|
To gate this on StateVersion, presumably I'd have to gate it on the
_next_ state version, so current unstable installs don't break?
Does that mean I'd have to check if versionOlder "21.03"?
|
|
Do we make unstable installs default to |
Yeah, we should probably only update the I'd also be fine with not having it conditional on stateVersion, but then it should really live in |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
@alyssais can you gate this on |
stale
bot
removed
the
2.status: stale
flokli
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
This way, we can use StateDirectory instead of a tmpfile rule.