Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/rss2email: globally install rss2email #85316

Merged
merged 1 commit into from Apr 18, 2020

Conversation

alyssais
Copy link
Member

For man pages.

@Ekleog
Copy link
Member

Ekleog commented Apr 15, 2020

Hmmm… The r2e that would be in $PATH would have no link whatsoever with the one enabled by the service as far as I remember, so it would sound like a footgun, but the manpage is a point.

Do you think it'd be reasonable to split the rss2email derivation to have rss2email.man, and only include the .man in systemPackages? This way it wouldn't be as much of a trap

@alyssais
Copy link
Member Author

What do you mean? it’s the same package as in the ExecStart?

@Ekleog
Copy link
Member

Ekleog commented Apr 15, 2020

Indeed, what I mean is doing r2e run won't actually run rss2email, because it'd operate as a different user -- so the r2e in $PATH would have no way to interoperate with the services.rss2email module -- contrarily to what I usually see with modules that make available something in systemPackages

@alyssais
Copy link
Member Author

alyssais commented Apr 16, 2020 via email

@Ekleog
Copy link
Member

Ekleog commented Apr 16, 2020

Then I guess I just never noticed these services, and this is good to go :) my experience has been mostly with (systemd and) opensmtpd, where the *ctl command is installed -- I haven't noticed many other packages globally-installing packages, but if I just missed them, then that's all good!

@alyssais alyssais merged commit 1b0d801 into NixOS:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants