Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: a118293bd017
Choose a base ref
...
head repository: NixOS/nix
compare: 2f9789c2e668
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Apr 13, 2020

  1. SourceExprCommand: allocate the vSourceExpr via uncollectable memory 

    Previously the memory would occasionally be collected during eval since
the GC doesn't consider the member variable as alive / doesn't scan the
region of memory where the pointer lives.

By using the traceable_allocator<T> allocator provided by Boehm GC we
can ensure the memory isn't collected. It should be properly freed when
SourceExprCommand goes out of scope.
    @andir
    andir committed Apr 13, 2020
    Copy the full SHA
    d2c3719 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Merge pull request #3492 from andir/nix-build-gc-free 

    SourceExprCommand: allocate the vSourceExpr via uncollectable memory
    @edolstra
    edolstra committed Apr 15, 2020
    Copy the full SHA
    2f9789c View commit details
    Browse the repository at this point in the history