Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS resolver security updates for "nxnsattack" #88159

Merged
merged 3 commits into from May 21, 2020
Merged

DNS resolver security updates for "nxnsattack" #88159

merged 3 commits into from May 21, 2020

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented May 19, 2020 •
edited

Motivation for this change

See e.g. https://en.blog.nic.cz/2020/05/19/nxnsattack-upgrade-resolvers-to-stop-new-kind-of-random-subdomain-attack/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • N/A Ensured that relevant documentation is up to date
  • (probably) Fits CONTRIBUTING.md.

@vcunat
Copy link
Member Author

vcunat commented May 19, 2020

All the updates should be quite minimalist, so I'm submitting them together and won't wait for long before merging. Unbound causes larger rebuilds, so I pushed it separately to staging-next as 73390e3.

@vcunat vcunat added the 9.needs: port to stable A PR needs a backport to the stable release. label May 19, 2020
@ofborg ofborg bot requested review from rnhmjoj, globin and peti May 19, 2020 09:45
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 88159 1

2 packages blacklisted:
- tests.nixos-functions.nixos-test
- tests.nixos-functions.nixosTest-test
24 packages built:
- acme-sh
- autofs5
- bashSnippets
- bind
- check-wmiplus
- cinnamon.cinnamon-session
- cinnamon.cjs
- cinnamon.nemo
- cinnamon.xapps
- dnsperf
- dnsutils
- dwm-status
- host
- inxi
- knot-resolver
- monitoring-plugins
- nmapsi4
- pdns-recursor
- python27Packages.xapp
- python37Packages.xapp
- python38Packages.xapp
- sssd
- testssl
- twa

rnhmjoj
rnhmjoj approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For pdns-recursor, I tested the update on my server and looks all right.
It should be safe to backport to 20.03.

@vcunat vcunat merged commit 198cd3a into NixOS:master May 21, 2020
@vcunat vcunat deleted the p/dns-nsnxattack branch May 21, 2020 13:31
@andir
Copy link
Member

andir commented May 22, 2020

@vcunat what would be the proper move forward for knot-resolver on the release branches? Bumping to 5.1 seems feasible.

@vcunat
Copy link
Member Author

vcunat commented May 22, 2020

Ah, yes. I thought I already bumped it during the embargo, but apparently I forgot. Incompatibilities are really tiny and so far we've confirmed no regression.

@vcunat
Copy link
Member Author

vcunat commented May 23, 2020

@rnhmjoj: for pdns-recursor in 20.03 the bump would also be larger than on master, adding https://blog.powerdns.com/2020/03/03/powerdns-recursor-4-3-0-released/ – on a brief look I see nothing that I would consider incompatible, but there are some changes in behavior.

vcunat added a commit that referenced this pull request May 23, 2020
@vcunat
bind: 9.14.11 -> 9.14.12 (security, PR #88159)
0b473aa 
https://www.isc.org/blogs/bind9-vulnerabilities-2020-05/
$ nix build -f nixos/release.nix tests.bind.x86_64-linux

(cherry picked from commit 13c485d)
vcunat added a commit that referenced this pull request May 23, 2020
@vcunat
knot-resolver: 5.1.0 -> 5.1.1 (security, PR #88159)
9712027 
https://en.blog.nic.cz/2020/05/19/nxnsattack-upgrade-resolvers-to-stop-new-kind-of-random-subdomain-attack/
(cherry picked from commit d0d9090)
vcunat added a commit that referenced this pull request May 23, 2020
@vcunat
bind: 9.14.9 -> 9.14.12 (security, PR #88159)
a689086 
https://www.isc.org/blogs/bind9-vulnerabilities-2020-05/
$ nix build -f nixos/release.nix tests.bind.x86_64-linux

(cherry picked from commit 13c485d)
In BIND case these are quite severe DoS risks, so let me backport to 19.09.
@rnhmjoj
Copy link
Contributor

rnhmjoj commented May 23, 2020

You are right, it may introduce some unwanted changes. Unfortunaly we have 4.3.0 on 20.03 but the the stable branch of pdns-recursor is 4.2.0, so the CVE patch are only backported to that version.

@vcunat
Copy link
Member Author

vcunat commented May 23, 2020 •
edited

Ah... silly me, they released also 4.2.2 for the CVE: https://blog.powerdns.com/2020/05/19/powerdns-recursor-4-3-1-4-2-2-and-4-1-16-released/

EDIT: to be clear, 20.03 had 4.2.1, so I did the CVE-only step to 4.2.2.

vcunat added a commit that referenced this pull request May 23, 2020
@vcunat
pdns-recursor: 4.2.1 -> 4.2.2 (security)
1a02977 
https://blog.powerdns.com/2020/05/19/powerdns-recursor-4-3-1-4-2-2-and-4-1-16-released/
$ nix build -f nixos/release.nix tests.pdns-recursor.x86_64-linux
NixPkgs master is on 4.3.x already; /cc that PR #88159
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label May 23, 2020
vcunat added a commit that referenced this pull request May 23, 2020
@vcunat
pdns-recursor: 4.2.0 -> 4.2.2 (security)
35eda4a 
https://blog.powerdns.com/2020/05/19/powerdns-recursor-4-3-1-4-2-2-and-4-1-16-released/
$ nix build -f nixos/release.nix tests.pdns-recursor.x86_64-linux
NixPkgs master is on 4.3.x already; /cc that PR #88159

(cherry picked from commit 1a02977)
@rnhmjoj
Copy link
Contributor

rnhmjoj commented May 23, 2020

EDIT: to be clear, 20.03 had 4.2.1, so I did the CVE-only step to 4.2.2.

Yeah, I was somehow convinced it was 4.3.0. Thank you.

@vcunat
Copy link
Member Author

vcunat commented Jun 1, 2020

BTW, upgrading BIND from 9.14 to 9.16 would probably be desirable soon. (But I won't be looking into that.)

BIND 9.16 has replaced 9.14 as the current stable version. This BIND release is the last one in the BIND 9.14 release train. For those needing long-term support, the current Extended Support Version (ESV) is BIND 9.11, which will be supported until at least December 2021. See https://kb.isc.org/docs/aa-00896 for details of ISC's software support policy.

ali-abrar added a commit to obsidiansystems/nixpkgs that referenced this pull request Nov 6, 2020
@ali-abrar
Merge remote-tracking branch 'upstream/nixos-19.09' into reflex-platf…
aec91d9 
…orm-wasm-support

* upstream/nixos-19.09: (795 commits)
  doc: rename guide to 'Nixpkgs Manual'
  libexif: 0.6.21 -> 0.6.22
  gnutls: 3.6.13 -> 3.6.14
  Merge NixOS#89474: thunderbird*: 68.8.0 -> 68.9.0 (security)
  wire-desktop: mac 3.17.3666 -> 3.18.3728
  wire-desktop: linux 3.17.2924 -> 3.18.2925
  ip2unix: 2.1.2 -> 2.1.3
  ip2unix: 2.1.1 -> 2.1.2
  ffmpeg_2_8: 2.8.15 -> 2.8.16
  ffmpeg-full: 4.2.2 -> 4.2.3
  ffmpeg_4: 4.2.2 -> 4.2.3
  pdns-recursor: 4.2.0 -> 4.2.2 (security)
  bind: 9.14.9 -> 9.14.12 (security, PR NixOS#88159)
  dovecot: v2.3.10 → v2.3.10.1
  dovecot: 2.3.9.3 -> 2.3.10
  chromium: Mark as insecure
  firefox: 76.0 -> 76.0.1
  firefox: Add patch to fix AES GCM IV bit size
  monero: fix rcp.restricted option
  Merge NixOS#87066: thunderbird*: 68.7.0 -> 68.8.0 (security)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@globin globin Awaiting requested review from globin

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vcunat @mweinelt @andir @rnhmjoj