Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud17: 17.0.4 -> 17.0.6, nextcloud18: 18.0.3 -> 18.0.4 #88084

Merged
merged 2 commits into from May 18, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented May 18, 2020

Changes:

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2020-8154 (affects 17 only I think)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata mmilata changed the title nextcloud17: 17.0.4 -> 17.0.6, nextcloud18: nextcloud17: 17.0.4 -> 17.0.6, nextcloud18: 18.0.3 -> 18.0.4 May 18, 2020
@ofborg ofborg bot requested review from bachp, globin, Ma27, schneefux and fpletz May 18, 2020 18:17
@Ma27 Ma27 added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels May 18, 2020
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextcloud18 working as intended

@Ma27 Ma27 merged commit 69711a2 into NixOS:master May 18, 2020
@Ma27
Copy link
Member

Ma27 commented May 18, 2020

Thanks! Ported to stable as 4166e36, 57e9220.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels May 18, 2020
@mmilata mmilata deleted the nextcloud-18.0.4 branch May 18, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants