Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not strip binary when darwin(OSX) #88091

Merged
merged 1 commit into from May 25, 2020
Merged

Do not strip binary when darwin(OSX) #88091

merged 1 commit into from May 25, 2020

Conversation

CorbanR
Copy link
Contributor

@CorbanR CorbanR commented May 18, 2020

Stripping the binary on OSX causes op(1password) to fail immediately.
Setting dontStrip = true; fixes the issue.
Additionally, adding a very simple installCheck section for testing
purposes.

Motivation for this change

To fix the 1password-cli(op) on darwin(OSX)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
    Tried on both linux and OSX with --option build-use-sandbox true
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [x ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Do not strip binary when darwin(OSX)
578ba6c 
Stripping the binary on OSX causes op(1password) to fail immediately.
Setting dontStrip = true; fixes the issue.
Additionally, adding a very simple installCheck section for testing
purposes.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 18, 2020
@ofborg ofborg bot requested review from marsam and joelburget May 18, 2020 21:17
knl
knl approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@knl knl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it helps on darwin.

@marsam marsam merged commit c640f7e into NixOS:master May 25, 2020
@CorbanR CorbanR deleted the 1password branch May 25, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knl knl knl approved these changes

@marsam marsam Awaiting requested review from marsam

@joelburget joelburget Awaiting requested review from joelburget

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CorbanR @knl @marsam @Janik-Haag