Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: don't build "podman-remote" #88104

Merged
merged 1 commit into from May 19, 2020
Merged

podman: don't build "podman-remote" #88104

merged 1 commit into from May 19, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 19, 2020

Motivation for this change

We're only installing podman.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor Author

zowoq commented May 19, 2020

@ofborg build podman

@zowoq
Copy link
Contributor Author

zowoq commented May 19, 2020

@ofborg test podman

@adisbladis
Copy link
Member

Why don't we install podman-remote instead of not building it?

@zowoq
Copy link
Contributor Author

zowoq commented May 19, 2020

Why don't we install podman-remote instead of not building it?

I don't know. My only intent with this PR is to remove the unnecessary build.

I'm not sure if just installing podman-remote works or if it requires anything else.

@adisbladis
Copy link
Member

I'm not sure if just installing podman-remote works or if it requires anything else.

Alright, fair enough.

@adisbladis adisbladis merged commit d6b5f95 into NixOS:master May 19, 2020
@zowoq zowoq deleted the podman branch May 19, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester Awaiting requested review from vdemeester

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@adisbladis adisbladis Awaiting requested review from adisbladis

@kalbasit kalbasit Awaiting requested review from kalbasit

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @adisbladis