Swapspace: dynamically manage swapspace on NixOS #88093
Conversation
| ###### implementation | ||
|
|
||
| config = mkIf cfg.enable { | ||
| systemd.services.swapspace = with pkgs; { |
There was a problem hiding this comment.
| systemd.services.swapspace = with pkgs; { | |
| systemd.services.swapspace = { |
you don't refer to things inside pkgs anywhere.
|
@wmertens can you address the changes requested? |
flokli
added
the
2.status: stale
|
@flokli yes sorry, they were very helpful, but this dropped off my radar. I'll address them this weekend |
|
@wmertens another poke ;-) |
stale
bot
removed
the
2.status: stale
|
@peterhoeg thanks for the thorough review, much appreciated. I'll update this this week. |
|
is this still worked on? |
wmertens
force-pushed
the
swapspace
branch
2 times, most recently
from
fe078cb
to
ef928e6
Compare
|
Ok, updated and rebased. Thank you all for your comments, is this good for merging? |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
based on reviews from langston-barrett, flokli and peterhoeg, thanks!
|
|
||
| nativeBuildInputs = [ autoreconfHook ]; | ||
|
|
||
| patchPhase = '' |
There was a problem hiding this comment.
| patchPhase = '' | |
| postPatch = '' |
| nativeBuildInputs = [ autoreconfHook ]; | ||
|
|
There was a problem hiding this comment.
| nativeBuildInputs = [ autoreconfHook ]; |
duped with line 14
| type = types.nullOr types.int; | ||
| default = null; | ||
| description = '' | ||
| Maximum size of a swapfile. |
There was a problem hiding this comment.
I think it would be great to explain what happens when this is set to null. Same for minSwapSize.
| description = '' | ||
| Cooldown period between changes. | ||
| SwapSpace will wait at least this many seconds before an action, | ||
| like removing a swapfile after adding one. |
There was a problem hiding this comment.
Is null then the same as 0 or how does it interact?
stale
bot
added
the
2.status: stale
|
Why is this staled out ? Does no one use dynamic swap on Nix? |
|
I haven't gotten around to all the proposed fixes yet and it's working fine
on my system so the sense of urgency is low :)
Feel free to add commits!
Wout.
…On Wed., Oct. 5, 2022, 2:21 p.m. MPK99 ***@***.***> wrote:
Why is this staled out ? Does no one use dynamic swap ?
—
Reply to this email directly, view it on GitHub
<#88093 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAANNFQCKPQG2U7WPW5D64LWBVXDTANCNFSM4NEOJOYQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
stale
bot
removed
the
2.status: stale
| + optionalString (cfg.cooldown != null) | ||
| " --cooldown=${toString cfg.cooldown}" | ||
| + optionalString (cfg.minSwapSize != null) | ||
| " --min_swapsize=${toString cfg.minSwapSize}" |
There was a problem hiding this comment.
From the documentation:
Never bother to allocate any swapfiles smaller than size bytes. There should be no need to change this variable except for testing.
I suggest removing this argument and the option. For testing, one can just use extraArgs.
|
You should reuse the upstream systemd unit file by copying it to the package output and then using it in the NixOS module. Let me know if you need help with that. I'll be happy to help you on this. |
|
having dynamic swap on my laptop (and I bet many other systems) would be so nice... Zswap seems to work better than zram and being able to have a dynamic swap system would help with not having to sacrifice a definite storage space |
wegank
added
the
2.status: stale
Motivation for this change
Using NixOS with dynamic swap size management, the way macOS does it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)