Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment.py: fixup mistakes in #1346 #1348

Merged
merged 2 commits into from May 19, 2020
Merged

deployment.py: fixup mistakes in #1346 #1348

merged 2 commits into from May 19, 2020
+6 −6

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented May 18, 2020

No description provided.

@grahamc grahamc mentioned this pull request May 18, 2020
Merged
@tewfik-ghariani
Copy link
Contributor

Can we use

if dep._destroyed_event:

instead of

if dep._destroyed_event is not None:

As far as I remember, it improves slightly the performance and surely it's easier to read

@grahamc
Copy link
Member Author

grahamc commented May 19, 2020

I think that is probably fine, what do you think @adisbladis?

@adisbladis
Copy link
Member

@grahamc Fine by me, since it's Optional[Event] it's always truthy when set.

@adisbladis adisbladis merged commit a12351e into NixOS:master May 19, 2020
@grahamc
Copy link
Member Author

grahamc commented May 19, 2020 •
edited

Thanks, @tewfik-ghariani and @adisbladis!

@grahamc grahamc deleted the fixup-1346 branch May 19, 2020 12:35
@tewfik-ghariani tewfik-ghariani mentioned this pull request Jun 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @tewfik-ghariani @adisbladis