Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optifine won't load in Magic Launcher 1.3.4 #2289

Open
TNTUP opened this issue Apr 5, 2019 · 9 comments
Open

Optifine won't load in Magic Launcher 1.3.4 #2289

TNTUP opened this issue Apr 5, 2019 · 9 comments

Comments

@TNTUP
Copy link

TNTUP commented Apr 5, 2019

Heya! If anyone still uses Magic Launcher for Optifine 1.13.2 like me you may be aware it does not longer works with ML. I've attempted a workaround, by comparing 1.12.2's json and 1.13.2 and the way it works, the "minecraftArguments" is no longer used in 1.13+. Instead it uses "arguments: game: blabla" to work.

I replaced arguments into minecraftArguments and removed every ", " but keeping json formatting and when I tested it on Magic Launcher, it worked! I got Optifine 1.13.2/1.14.4/1.15.2/1.16.1/1.16.2 to work with Magic Launcher even I can make snapshots to work aswell but my main concern is making future versions to work with Magic Launcher, despite being unsupported maybe?

Using vanilla 1.13.2 (and optifine) without my workarond throws this error
https://pastebin.com/Rc2mxnDQ
I noticed there's issues about this related to TLauncher which I'm not using it and what I've seen it misses ASM classes I don't know?

What I'm asking, if Sp418x can add 1.13+ compatibility for Optifine (including vanilla snapshots, future versions of Forge, or other launchwrappers like labymod? ect) but asking support for Forge or anything is quite offtopic. So I can avoid using my own workaround everytime I need to edit the version's json file manually to make it work (eg snapshots). I keep the original version then copy-paste it and I add ".ml" at the end of the folder/file names and in the json then rearrange the "arguments" to make it work :)

Also, my english is very bad so sorry if there's any bad grammar :X

PS: I've made this issue because Sp maintains (or its inactive/discontinued?) MagicLauncher and posts on minecraftforums.net seems to be ignored so I try seeking support here as Optifine development is active.

PSS: I know I can use Mojang's launcher, but the ** issue is, token based auth and sometimes it happens that they expire and forces me to re-enter the password and I never tried how many accounts Mojang Launcher can hold. I was lucky when Sp increased the limit to 100. That would be anotherr suggestion if Sp can add a config or increasing to 200 or whatever for offline purposes.

@TNTUP
Copy link
Author

TNTUP commented May 31, 2019

Can't even run 1.14.2 pre6 or 1.14 ones. Is MagicLauncher still supported by you @sp614x ? And if thats possible to increase the account limit to 200? Or allowing us to define what limit of accounts. I really love this launcher and Optifine

@sp614x
Copy link
Owner

sp614x commented Aug 5, 2019

The MagicLauncher is not actively developed anymore.
It may be updated to support 1.13+, but there is no guarantee when this would be.

@TNTUP

This comment has been minimized.

@TNTUP

This comment has been minimized.

@TNTUP TNTUP closed this as completed Aug 6, 2019
@TNTUP

This comment has been minimized.

@TNTUP TNTUP reopened this Sep 9, 2019
@TNTUP

This comment has been minimized.

@TNTUP

This comment has been minimized.

@TNTUP

This comment has been minimized.

@TNTUP TNTUP closed this as completed May 24, 2020
@TNTUP
Copy link
Author

TNTUP commented Aug 14, 2020

Reopening, the alternative I had used has far more issues so I reverted using Magic Launcher.

I'd pay for it to get updated or updating it for my own uses. I wish to get Vanilla/Optifine and other deratives to work with this launcher... My workaround still works but its a pain to manually edit every newer versions :(

Sp614x, if you see this message, I hope deeply you'll update MagicLauncher when you want (maybe never).. There no suitable launchers for me to use for easy account management, auto-renewing token etc.

The workaround to get vanilla/optifine to work is adding "minecraftArguments" in your version' json file including their parameters to launch. Doesn't work with Forge/Fabric, sadly

@TNTUP TNTUP reopened this Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants