Converting town-owned road returns ambiguous/unhelpful error message #8162
Comments
|
The error message occurs in my games (JGRPP 0.34.2) every time, I use the convert tool and the road piece already has the type, I want to convert it to (present road type == target type). It occurs whoever the road piece owns (town or me). |
|
I think these two incompatibility messages may be in place instead of the owned by message because since an error has to be made artificially with MakeError rather than failing organically there is no information about the owner that is given to CommandCost, resulting in it making something up if there needs to be an owner and sometimes crashing the game in the process. That seems to be what happened when I did the substitutions. The incompatibility strings are the same each time and only require the fact that there was an error, not the nonexistent information besides that. Perhaps arguments could be added to MakeError, but that is beyond the scope of this issue. Honestly, I don't see the issue with just allowing road conversions within towns in the first place. These roads can already be manipulated like any other road except in this instance, the alteration comes out of your pocket in the same way it would for other roads, and while this would essentially make the base road already paid for you, the vehicles don't care about whether a road was paid for by you or not. The only thing that might need to be added is potentially an ownership change. And, of course, this would still make the incompatible road error never used. EDIT: Given that you get relationship penalties for destroying roads in a town the same should happen for conversions since the road here is as well ruined for their purposes. And since it is already so the owner should switch to avoid more penalties for more changes if it doesn't already since you can't ruin it more. I'd have to look through it more to know what would need to be done regarding this. |
|
Actually, scratch that. Simply adding GetNameofOwner(OWNER_TOWN, tile); under the two occurrences of incompatible road in addition to replacing them with owned by solves the owner name problem and crash. |
This changes the error when you attempt to convert a road owned by a town to another road, specifying that it's owned by the town rather than simply being incompatible. As the original poster of the issue pointed out, these seemed to be the only occurences of the incompatible road string, so now it's unused, but they would be left untouched in case of future use or since changing it to a different error would do the work of removing it then. If requested, it likely wouldn't be too difficult to remove the string entirely.
This changes the error when you attempt to convert a road owned by a town to another road, specifying that it's owned by the town rather than simply being incompatible. As the original poster of the issue pointed out, these seemed to be the only occurences of the incompatible road string, so now it's unused, but they would be left untouched in case of future use or since changing it to a different error would do the work of removing it then. If requested, it likely wouldn't be too difficult to remove the string entirely.
This changes the error when you attempt to convert a road owned by a town to another road, specifying that it's owned by the town rather than simply being incompatible. As the original poster of the issue pointed out, these seemed to be the only occurences of the incompatible road string, so now it's unused, but they would be left untouched in case of future use or since changing it to a different error would do the work of removing it then. If requested, it likely wouldn't be too difficult to remove the string entirely.
This changes the error when you attempt to convert a road owned by a town to another road, specifying that it's owned by the town rather than simply being incompatible. As the original poster of the issue pointed out, these seemed to be the only occurences of the incompatible road string, so now it's unused, but they would be left untouched in case of future use or since changing it to a different error would do the work of removing it then. If requested, it likely wouldn't be too difficult to remove the string entirely.
Version of OpenTTD
master-20200509 (since NotRoadTypes was merged)
Expected result
The error message returned is something like "owned by {TOWN}" (
STR_ERROR_OWNED_BY).Actual result
The error message returned is "incompatible road" (
STR_ERROR_INCOMPATIBLE_ROAD).Steps to reproduce
Note
The following appear to be the only two unique occurences of the error message. They were both added in the NRT branch.
OpenTTD/src/road_cmd.cpp
Line 2398 in b8a896d
OpenTTD/src/road_cmd.cpp
Line 2444 in b8a896d
If both are removed, then the error message may also need to be removed as well as it would no longer be used.
The text was updated successfully, but these errors were encountered: