Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libexif: 0.6.21 -> 0.6.22 #88100

Merged
merged 1 commit into from Jun 4, 2020
Merged

libexif: 0.6.21 -> 0.6.22 #88100

merged 1 commit into from Jun 4, 2020

Conversation

erictapen
Copy link
Member

Motivation for this change
Things done
  • Bumped libexif
  • removed old patches that are now integrated in the release (see also the NEWS for that)
  • enabled building from git sources
  • made sure cross compilation works
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed May 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this change causes over 500 rebuilds, do you mind targeting the staging branch

git rebase --onto=staging HEAD~1
git push .. ... --force

then change the base branch in the github PR from master -> staging

See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch for more details on staging branch

@jonringer
Copy link
Contributor

also, duplicate of #88096

@mmilata
Copy link
Member

mmilata commented May 19, 2020

In #88096 I didn't look into cross compilation so it's probably better to merge this one.

Another difference is that the other PR uses the release archive which doesn't need autoreconf, not sure what is preferable.

@erictapen erictapen changed the base branch from master to staging May 19, 2020 11:13
@erictapen
Copy link
Member Author

@mmilata Oh sorry, this time I didn't look for duplicates because I felt I'd be early enough. Will check next time definetely.

I'd always prefer building from source, as this leverages the hurdle for upstream contributions.

@jonringer Thanks, I know about the staging branch but first wanted to ask ofBorg how much is going to be rebuilt.

@erictapen erictapen mentioned this pull request May 31, 2020
Closed
10 tasks
prusnak
prusnak requested changes May 31, 2020
View reviewed changes
pkgs/development/libraries/libexif/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libexif/default.nix Outdated Show resolved Hide resolved
@erictapen
libexif: 0.6.21 -> 0.6.22
a31129d 
Also:
- build from git
- enable cross compilation
@erictapen
Copy link
Member Author

@prusnak Thanks for the review. I added your suggestions and rebased to latest staging.

@FRidh FRidh merged commit e761cfe into NixOS:staging Jun 4, 2020
@erictapen erictapen mentioned this pull request Jun 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@erictapen @jonringer @mmilata @prusnak @FRidh @TredwellGit