New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/display-managers: Use dbus socket unit shipped by upstream #88101
Conversation
This ensures a correct DBUS_SESSION_BUS_ADDRESS environment variable is set and imported into the systemd user environment. Previously this would refer to a non-existing path preventing commands interacting with the systemd manager from working. Closes NixOS#87502
40d8786
to
effceb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me 👍
This seems to have broken the Gnome3 test and I don't understand why. |
Hmm, that seems pretty weird as gnome doesn't launch through that code path (it just uses the upstream session files). The last trunk-combined eval reports a gnome test failure: https://hydra.nixos.org/build/119237820. I didn't investigate it further, but it could be an unrelated issue. |
I thought it was weird too.. Actually this error on Hydra is exactly what I was seeing too. |
@GrahamcOfBorg test plasma5 i3wm gnome3 systemd |
Since this doesn't seem to break anything and fixes a super annoying and hard to track down problem I'm just gonna go ahead and merge. |
Thank you so much @adisbladis |
It doesn't set Manually running |
@eadwu It does set it in the |
My service looks fine but I don't have the env set
|
The I'm curious, though, why you aren't getting the "Unit xyz.service not found" error for dbus activated services. For example Gnome Terminal. Search for "Error constructing proxy" in #17943 (comment) to see what I mean. Is you gnome-terminal package installed in the system or user profile? |
I don't have Here's some output when signing a commit
Running pinentry directly
If I revert this commit, |
@eadwu Could you try to apply adisbladis@18a0db3 and see if this fixes it for you? |
@eadwu I've left |
Yeah I figured out I kept the reverted commit in my nixpkgs after posting it. |
@adisbladis That patch exports On other details, it seems this might(?) because of how a specific way an applications asks for gpg-agent or pinentry (not sure how it works). Without the patch and without |
Alright, pushed fixup in 0f1eb8c. |
This ensures a correct DBUS_SESSION_BUS_ADDRESS environment variable
is set and imported into the systemd user environment.
Previously this would refer to a non-existing path preventing commands
interacting with the systemd manager from working.
Closes #87502
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)