Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.async_shell: remove at 109.28.03 #85987

Merged
merged 1 commit into from Apr 27, 2020
Merged

ocamlPackages.async_shell: remove at 109.28.03 #85987

merged 1 commit into from Apr 27, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Apr 25, 2020

Motivation for this change

This is a legacy version for OCaml 4.02

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
ocamlPackages.async_shell: remove at 109.28.03
05db4f4 
This is a legacy version for OCaml 4.02
@vbgl
Copy link
Contributor Author

vbgl commented Apr 25, 2020

@GrahamcOfBorg build ocamlPackages.async_shell

@vbgl vbgl assigned vbgl and unassigned vbgl Apr 27, 2020
@Mic92 Mic92 merged commit 32e4d07 into NixOS:master Apr 27, 2020
@vbgl vbgl deleted the ocaml-async_shell-remove-legacy branch April 27, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @Mic92