Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mathcomp 1.11 #86006

Closed
wants to merge 6 commits into from
Closed

Mathcomp 1.11 #86006

wants to merge 6 commits into from

Conversation

CohenCyril
Copy link
Contributor

@CohenCyril CohenCyril commented Apr 25, 2020

Motivation for this change

The way Coq mathcomp core and extra packages were generated did not allow enough freedom to both limit the number of exposed derivation and dynamically patch one. Now it does and it is highly configurable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CohenCyril
Copy link
Contributor Author

@GrahamcOfBorg build coqPackages coqPackages_8_10 coqPackages_8_11

@CohenCyril
Copy link
Contributor Author

@GrahamcOfBorg build coqPackages coqPackages_8_10 coqPackages_8_11

@CohenCyril CohenCyril closed this Apr 26, 2020
@CohenCyril
Copy link
Contributor Author

Re-submitted as #86088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants