Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.coc-rust-analyzer: init at 2020-04-24 #86044

Merged
merged 3 commits into from Apr 27, 2020
Merged

vimPlugins.coc-rust-analyzer: init at 2020-04-24 #86044

merged 3 commits into from Apr 27, 2020

Conversation

samhug
Copy link
Contributor

@samhug samhug commented Apr 26, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
Copy link
Member

zimbatm commented Apr 26, 2020

builder for '/nix/store/z9w7xnfj8awx0i1hmv47p2pixkbfi52f-node_pulp-14.0.0.drv' failed with exit code 1; last 10 log lines:
  npm ERR! errno ENOENT
  npm ERR! purescript@0.12.5 postinstall: `install-purescript --purs-ver=0.12.5`
  npm ERR! spawn ENOENT
  npm ERR! 
  npm ERR! Failed at the purescript@0.12.5 postinstall script.
  npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
  
  npm ERR! A complete log of this run can be found in:
  npm ERR!     /build/.npm/_logs/2020-04-26T11_57_39_988Z-debug.log

@samhug
Copy link
Contributor Author

samhug commented Apr 26, 2020

@zimbatm Thanks for taking a look at this. Sorry, I should've caught that failure earlier.

I'm not very familiar with nodePackages so I'm not sure how to resolve that failure.
I've dropped the commit containing my initial run of node-packages/generate.sh which bumped all the versions and instead only included the commit with the subsequent run that added nodePackages.coc-rust-analyzer.

This reduces the scope of the PR and nixpkgs-review passes now. I'm not sure what the policy or best-practice is regarding nodePackages additions and version bumps though.

@Mic92
Copy link
Member

Mic92 commented Apr 27, 2020

The npm package was broken before. Not a regression of this PR.

@Mic92
Copy link
Member

Mic92 commented Apr 27, 2020

Result of nixpkgs-review pr 86044 1

21 packages built:
- vimPlugins.coc-nvim
- vimPlugins.coc-rust-analyzer
- vimPlugins.denite-nvim
- vimPlugins.iceberg-vim
- vimPlugins.julia-vim
- vimPlugins.neoformat
- vimPlugins.neoterm
- vimPlugins.nvim-lsp
- vimPlugins.tagbar
- vimPlugins.tender-vim
- vimPlugins.vim
- vimPlugins.vim-airline
- vimPlugins.vim-fugitive
- vimPlugins.vim-gitgutter
- vimPlugins.vim-go
- vimPlugins.vim-javacomplete2
- vimPlugins.vim-snippets
- vimPlugins.vim-subversive
- vimPlugins.vim-tmux-navigator
- vimPlugins.vimtex
- vimPlugins.vista-vim

@Mic92 Mic92 merged commit 16e83ef into NixOS:master Apr 27, 2020
@samhug samhug deleted the coc-rust-analyzer branch April 27, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants