Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] pythonPackages.stem: unbroken #86008

Merged
merged 2 commits into from Apr 25, 2020
Merged

[20.03] pythonPackages.stem: unbroken #86008

merged 2 commits into from Apr 25, 2020

Conversation

ryneeverett
Copy link
Contributor

Motivation for this change

A third attempt after #85642 which I hadn't recognized as a backport
of #81679. Same diff, brand new history.

The bug is just with the test suite on python 3.8 which was fixed in 1.8.0.
See bug report: https://trac.torproject.org/projects/tor/ticket/30847.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

colemickens and others added 2 commits April 25, 2020 15:04
@colemickens @ryneeverett
pythonPackages.stem: 1.7.1 -> 1.8.0
7bb0ca2 
(cherry picked from commit f539a47)
@ryneeverett
pythonPackages.stem: remove marked as broken
e349f5c 
A third attempt after NixOS#85642 which I hadn't recognized as a backport
of NixOS#81679.

The bug is just with the test suite on python 3.8 which was fixed in 1.8.0.
See bug report: https://trac.torproject.org/projects/tor/ticket/30847.

(cherry picked from commit 618cdd2)
@ofborg ofborg bot requested a review from Phreedom April 25, 2020 15:28
@ryneeverett ryneeverett mentioned this pull request Apr 25, 2020
Closed
10 tasks
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build python37Packages.stem python38Packages.stem

@worldofpeace
Copy link
Contributor

@ryneeverett It still appears to be broken on darwin. Can we fix that or mark it broken on that platform?

@ryneeverett
Copy link
Contributor Author

@worldofpeace This is the first time I've seen that particular error and I'm pretty sure it built on darwin when this identical diff was built by ofborg in #85642. Any chance this is an unrelated CI error?

@worldofpeace
Copy link
Contributor

@worldofpeace This is the first time I've seen that particular error and I'm pretty sure it built on darwin when this identical diff was built by ofborg in #85642. Any chance this is an unrelated CI error?

I could try it again, be since this is now on release-20.03 it's going to be different.

@GrahamcOfBorg build python37Packages.stem python38Packages.stem

@worldofpeace
Copy link
Contributor

@worldofpeace This is the first time I've seen that particular error and I'm pretty sure it built on darwin when this identical diff was built by ofborg in #85642. Any chance this is an unrelated CI error?

We're in luck, it worked ✨

@worldofpeace worldofpeace merged commit 6c2e7b2 into NixOS:release-20.03 Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryneeverett @worldofpeace @colemickens