Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nscd: be more specific in the nscd.enable description on what breaks #86010

Merged
merged 1 commit into from Apr 25, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 25, 2020

Motivation for this change

#43607

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
Copy link
Member

dasJ commented Apr 25, 2020

Maybe also mention that turning this off/on requires a reboot as processes may have the old state in their caches?

@ajs124
Copy link
Member

ajs124 commented Apr 25, 2020

The new description is definitely better, but I'd guess it still doesn't mean much to most people. Tbh, before I was forced to look into it, I barely knew anything about the whole mechanism (not that I really understand a lot about it now…).

So maybe we should give a "real world" example. Something along the lines of "For example, this means you will not be able to see which dynamic user owns a file or directory."

@flokli
Copy link
Contributor Author

flokli commented Apr 25, 2020

I see the description mostly as a way to further discourage people to disable this. The default is to enable this, people disabling it will eventually read the description and don't disable it ;-)

@dasJ if I understood the NSS NixOS module properly, there also should assertions failing when any NSS module except the systemd one is enabled, but nscd disabled, right?

@dasJ
Copy link
Member

dasJ commented Apr 25, 2020

Yes, you are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants