carnix workspace #471
Merged
carnix workspace #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carnix doesn't properly handle includes for workspace members, this works around the issue by specifying what should be generated directly in Cargo.toml. https://nest.pijul.com/pmeunier/carnix/discussions/46
Currently broken due to the .dSYM folders it generates next to the binaries. See NixOS/nixpkgs#83488
cole-h
reviewed
Apr 25, 2020
| @@ -2,7 +2,7 @@ | |||
| name = "ofborg" | |||
| version = "0.1.8" | |||
| authors = ["Graham Christensen <graham@grahamc.com>"] | |||
| include = ["Cargo.toml", "Cargo.lock", "src", "test-srcs", "build.rs"] | |||
| include = ["Cargo.toml", "ofborg"] # TODO remove when carnix is fixed | |||
There was a problem hiding this comment.
What needs to be "fixed" in Carnix, and what would be removed? The entire include line? Just the ofborg folder from the includes?
There was a problem hiding this comment.
Take a look at 96639e9, that only contains the workaround. There are 2 issues I noticed.
- the includes for a member have a space which means the filter doesn't match anything and nix filters the sources out
- specified includes are not relative to the member and declaring nested paths doesn't work either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.