Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.cow: 2.2.0 -> 2.4.0 #85207

Merged
merged 1 commit into from Apr 25, 2020
Merged

ocamlPackages.cow: 2.2.0 -> 2.4.0 #85207

merged 1 commit into from Apr 25, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Update cow. Contains switch to dune which makes the package cleaner. Also fixed the package name, attribute was correct.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build ocamlPackages.cow

@sternenseemann
Copy link
Member Author

@vbgl Any concerns merging this? This also works with a local ocaml project.

@vbgl
Copy link
Contributor

vbgl commented Apr 25, 2020

@GrahamcOfBorg build ocamlPackages.cow

@vbgl vbgl merged commit 79e6d13 into NixOS:master Apr 25, 2020
@sternenseemann sternenseemann deleted the cow branch April 25, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @vbgl