bgpq4: init at 0.0.6 #86072
Merged
bgpq4: init at 0.0.6 #86072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, can you split the commit into 2? one for the maintainer addition and one for the package. |
vincentbernat
force-pushed
the
feature/bgpq4
branch
from
28ad50e
to
38d9db6
Compare
|
Sure! Done. |
Lassulus
reviewed
Aug 27, 2020
| src = fetchFromGitHub { | ||
| owner = "bgp"; | ||
| repo = pname; | ||
| rev = "${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "${version}"; | |
| rev = version; |
This is a fork of bgpq3. It is still unclear if it will superseed bgpq3. It is mostly compatible with additional features, like support for Mikrotik devices. It also defaults to NTT IRR server instead of RADB.
vincentbernat
force-pushed
the
feature/bgpq4
branch
from
38d9db6
to
c463b54
Compare
|
❦ 27 août 2020 11:16 -07, Lassulus:
+ rev = "${version}";
```suggestion
rev = version;
```
Thanks. Dunno why I didn't do that!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a fork of bgpq3. It is still unclear if it will superseed
bgpq3. It is mostly compatible with additional features, like support
for Mikrotik devices. It also defaults to NTT IRR server instead of
RADB.
cc @B4dM4n
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)