Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pycoin: init at 0.90.20200322 #85994

Merged
merged 1 commit into from Jun 24, 2020
Merged

pythonPackages.pycoin: init at 0.90.20200322 #85994

merged 1 commit into from Jun 24, 2020

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Apr 25, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

drewrisinger
drewrisinger suggested changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks pretty good.

Few comments on reducing extra patch files/verbosity of test section.
@GrahamcOfBorg build python27Packages.pycoin python37Packages.pycoin python38Packages.pycoin

pkgs/development/python-modules/pycoin/hardcode-gnupg-path.patch Outdated Show resolved Hide resolved
pkgs/development/python-modules/pycoin/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pycoin/default.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build python27Packages.pycoin python37Packages.pycoin python38Packages.pycoin

@nyanloutre nyanloutre force-pushed the python_pycoin_init branch 2 times, most recently from 05b6579 to 4c53501 Compare April 27, 2020 21:05
@nyanloutre
Copy link
Member Author

Hello @drewrisinger
Thanks for the inputs, I think everything is fixed.

drewrisinger
drewrisinger suggested changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM minus comments.
Haven't built.

pkgs/development/python-modules/pycoin/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pycoin/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pycoin/default.nix Show resolved Hide resolved
pkgs/development/python-modules/pycoin/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pycoin/default.nix Show resolved Hide resolved
@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build python27packages.pycoin python37Packages.pycoin python38Packages.pycoin

@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build python27Packages.pycoin python37Packages.pycoin python38Packages.pycoin

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/172

jonringer
jonringer approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests 👍

https://github.com/NixOS/nixpkgs/pull/85994
3 packages built:
python27Packages.pycoin python37Packages.pycoin python38Packages.pycoin

@jonringer jonringer merged commit 2b11dcd into NixOS:master Jun 24, 2020
@nyanloutre nyanloutre deleted the python_pycoin_init branch June 25, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger requested changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @drewrisinger @nixos-discourse @jonringer