New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
khal: standardize derivation #85993
khal: standardize derivation #85993
Conversation
@GrahamcOfBorg build |
How this improves the situation? |
6cd0f03
to
56b6fd0
Compare
56b6fd0
to
b464d2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they need to be used as libraries, add them there. If they're also used as applications, use toPythonApplication
in all-packages.nix
.
e7c9538
to
4ea8d2a
Compare
29eb95d
to
a0c0ce3
Compare
BTW @FRidh I encountered that |
Use toPythonApplication and use callPackage from python-packages.nix. Make vdirsyncerStable somewhat functional again, but mark it as broken for Python 3.6 or higher.
Don't know why they were there in the first place :/.
I'm closing in favor of smaller PRs which hopefully will be easier to review. |
Motivation for this change
A few days ago, when updating all of my packages, I encountered build errors for khal / vdirsyncer mostly due to failing tests. When quickly patching an overlay to fix that, I noticed a few bad things in khal's
default.nix
:pkgs
is an argument to the derivation. This is not good because:khal
such aspkgs.vdirsyncer
. You have to use:pkgs
argument.with python3.pkgs;
at the top - which makes it hard to derive python deps and non python deps (readability).pkgs.vdirsyncer
was used inpropagatedBuildInputs
. This is bad because:vdirsyncerStable
.Now, on master (without this PR) the tests don't fail but I strongly think this change is beneficial, for general maintainability and conformism with other unwritten conventions in Nixpkgs.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)