Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fd to rebuild untracked files #414

Merged
merged 1 commit into from Apr 28, 2020
Merged

Conversation

milibopp
Copy link
Contributor

Fixes #410

`git ls-files` only traces files that are already in Git. When adding
new content, this is inconvenient. `fd` searches the entire directory
irrespective of the files' status in Git. However, it still respects
.gitignore files, so that it ignores build artifacts.

Hm… this is my first time touching a flake. Traditionally I would have added this package to shell.nix. Is it okay to add it under buildInputs, even though it is only developer tooling? Or do we have a better place for such things?

By the way git was also not in there… of course, everyone has Git already, making this rarely a practical problem. But still in a pure nix-shell git ls-files | entr make fails.

Fixes NixOS#410

`git ls-files` only traces files that are already in Git. When adding
new content, this is inconvenient. `fd` searches the entire directory
irrespective of the files' status in Git. However, it still respects
.gitignore files, so that it ignores build artifacts.
@garbas garbas merged commit 47ac357 into NixOS:master Apr 28, 2020
@milibopp milibopp deleted the fd-entr-make branch April 29, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants