Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nixos-installer: use temporary directory on target filesystem #85996

Merged
merged 1 commit into from May 8, 2020
Merged

nixos/nixos-installer: use temporary directory on target filesystem #85996

merged 1 commit into from May 8, 2020

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Apr 25, 2020 •
edited

Motivation for this change

This should fix 'No space left on device' on systems with low amount of RAM when there is a need to build something like Linux kernel.

Also fix #77481

How to test this:

  • boot installer on machine with <=2G of RAM
  • mount filesystems, generate config
  • add this to configuration:
{
  boot.kernelPatches = [ {
    name = "crashdump-config";
    patch = null;
    extraConfig = ''
      CRASH_DUMP y
      DEBUG_INFO y
      PROC_VMCORE y
      LOCKUP_DETECTOR y
      HARDLOCKUP_DETECTOR y
    '';
  } ];
}
  • start nixos-install

Without this patch nix build will fail to unpack kernel sources into /tmp (which is on tmpfs on installation).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mic92

@misuzu
nixos/nixos-installer: use temporary directory on target filesystem
5700232 
nix build should store it's temporary files on target filesystem.
This should fix 'No space left on device' on systems
with low amount of RAM when there is a need to build something
like Linux kernel
@misuzu misuzu marked this pull request as ready for review April 25, 2020 13:25
@xaverdh
Copy link
Contributor

xaverdh commented Apr 26, 2020

Maybe this should be behind a flag or something?

@misuzu
Copy link
Contributor Author

misuzu commented Apr 26, 2020

Maybe this should be behind a flag or something?

This should be default behavior. Installer should work under any conditions without obscure flags or environment variables.
Temporary directory can still be changed using TMPDIR environment variable by expert users but i don't see much reason to do so.

@rasendubi
Copy link
Member

@GrahamcOfBorg test installer

@rasendubi rasendubi merged commit afbab5a into NixOS:master May 8, 2020
@misuzu misuzu deleted the nixos-install-low-memory branch April 22, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos-install does not remove its temporary directory
4 participants
@misuzu @xaverdh @rasendubi @Mic92