rustc: 1.42.0 -> 1.43.0 #85997
Merged
rustc: 1.42.0 -> 1.43.0 #85997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kept 1.42 around for Thunderbird. i686-apple-darwin is no longer supported upstream. We could still support building it, for this one release, since we have the binary for the previous release, (or bootstrap it for future releases from Rust 1.42,) but since this release is the one that drops support, I think it makes sense to do it now. (And probably nobody is using it anyway.)
|
@GrahamcOfBorg build fd |
|
Still waiting for somebody to test on Darwin… |
LnL7
approved these changes
May 8, 2020
|
Awesome, thanks for testing! |
|
Firefox also built on Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kept 1.42 around for Thunderbird.
i686-apple-darwin is no longer supported upstream. We could still
support building it, for this one release, since we have the binary
for the previous release, (or bootstrap it for future releases from
Rust 1.42,) but since this release is the one that drops support, I
think it makes sense to do it now. (And probably nobody is using it
anyway.)
I’ve built fd and Thunderbird (with previous Rust) on x86_64. I haven’t been able to try Firefox because of #84283.
So this means I’ll need some help: