Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [Script] Improve copying a list into another empty list. #8097

Merged
merged 1 commit into from Apr 26, 2020

Conversation

michicc
Copy link
Member

@michicc michicc commented Apr 25, 2020

No description provided.

@LordAro
Copy link
Member

LordAro commented Apr 26, 2020

It's not clear how this makes any difference at all - if the list is empty, surely the iteration doesn't do anything?

@SamuXarick
Copy link
Contributor

Sem Título

@glx22
Copy link
Contributor

glx22 commented Apr 26, 2020

The iterations happens on the added list, not on the destination.

Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense

@michicc michicc merged commit 1f1345d into OpenTTD:master Apr 26, 2020
@michicc michicc deleted the pr/script_list_add_empty branch April 26, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants