Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump jedi versions (and its dependency parso) #86073

Closed
wants to merge 0 commits into from
Closed

Bump jedi versions (and its dependency parso) #86073

wants to merge 0 commits into from

Conversation

yipengsun
Copy link
Contributor

@yipengsun yipengsun commented Apr 26, 2020 •
edited

Motivation for this change

I'm using coc.nvim as my auto-completion helper in nvim. Upon updating it, it requires a newer version of jedi (0.17.0 instead of 0.15.2). So I'd like to upgrade jedi to the latest version.

parso is a jedi dependency. The latest jedi requires a newer version of this, so I updated that too.

Things done

I've put these derivations to a local overlay, and they seem to be working on macOS.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh self-assigned this Apr 27, 2020
@Mic92
Copy link
Member

Mic92 commented Apr 27, 2020

Seems to break python-language-server.

@Mic92
Copy link
Member

Mic92 commented Apr 27, 2020

Not sure if jedi 0.17 indeed breaks pyls: https://github.com/palantir/python-language-server/blob/develop/setup.py#L38

@Mic92
Copy link
Member

Mic92 commented Apr 27, 2020

Yes. pyls needs palantir/python-language-server#781 before it works with this jedi version.

@yipengsun
Copy link
Contributor Author

Then it is better to wait until they support newer jedi. Meanwhile these updates can live in my local overlay.

@veprbl veprbl added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Apr 27, 2020
@Mic92
Copy link
Member

Mic92 commented Apr 27, 2020

We could downgrade coc.nvim in nixpkgs to a version that works with the old jedi version in the meantime.

@yipengsun
Copy link
Contributor Author

yipengsun commented Apr 27, 2020 •
edited

Actually there's no need to downgrade coc-python. The master branch of nixpkgs tracks coc-python 1.2.9, which is released in Feb. This version only requires jedi >= 0.13.0:

pythonFiles/completion.py:    digits = jedi.__version__.split('.')
pythonFiles/completion.py:         raise RuntimeError('Jedi version %s too old, requires >= 0.13.0' % (jedi.__version__))

I was having problem because I use vim-plug to manage my vim plugins, not nix.

@yipengsun
Copy link
Contributor Author

yipengsun commented Jun 16, 2020 •
edited

I think pyls now works with jedi 0.17.0.

@Mic92
Copy link
Member

Mic92 commented Jun 16, 2020

Yes we have it in staging-next now as well as the jedi bump.

Mic92
Mic92 reviewed Jun 16, 2020
View reviewed changes
pkgs/development/python-modules/jedi/default.nix Outdated
@@ -2,17 +2,13 @@

buildPythonPackage rec {
pname = "jedi";
version = "0.15.2";
version = "0.17.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/NixOS/nixpkgs/blob/staging-next/pkgs/development/python-modules/jedi/default.nix#L15

Mic92
Mic92 reviewed Jun 16, 2020
View reviewed changes
pkgs/development/python-modules/parso/default.nix Outdated
@@ -6,11 +6,11 @@

buildPythonPackage rec {
pname = "parso";
version = "0.5.2";
version = "0.7.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs/pkgs/development/python-modules/parso/default.nix

Line 9 in 5815eca

version = "0.7.0";

@veprbl veprbl removed the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Jun 16, 2020
Mic92
Mic92 reviewed Jun 16, 2020
View reviewed changes
pkgs/development/python-modules/jedi/default.nix Outdated
};

postPatch = ''
substituteInPlace requirements.txt --replace "parso==0.1.0" "parso"
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cherry-picked this change here: https://github.com/NixOS/nixpkgs/pull/90641/files

@yipengsun yipengsun closed this Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yipengsun @Mic92 @veprbl @FRidh @Janik-Haag