terraform-providers: updates and cleanups #86053
Conversation
| hash = "sha256-+6jRjcManQdoKh7ewOJI1UaulY5OSbkIUHmtrBI33u4="; | ||
| }; | ||
|
|
||
| modSha256 = "sha256-gz+t50uHFj4BQnJg6kOJI/joJVE+usLpVzTqziek2wY="; |
There was a problem hiding this comment.
They don't use a vendor folder, right?
There was a problem hiding this comment.
Even if they do, buildGoModule does not support invocations without modSha256 at the moment.
There was a problem hiding this comment.
Well, we do have somewhat limited support for these kind of terraform modules with patchGoModVendor - maybe open an issue upstream and ask if they plan to package their modules in the future too?
Then we could use the generic updater framework we already have. cc @mmilata
There was a problem hiding this comment.
It's possible to use nix-prefetch to get the latest checksum. I use this in nix-update
There was a problem hiding this comment.
They don't use a vendor folder, right?
I wish, otherwise I would have used the other method.
There was a problem hiding this comment.
There are a number of improvements that we could do around the update-all script that are out of scope for this PR but that would nice to have soon:
- avoid re-fetching if the version hasn't change. At the moment
update-allprefeteches all the repos even if they are already indata.nix - support a "go repo type" as a second argument to the slugs to handle these other cases
- plug with the rytantm updater bot somehow
There was a problem hiding this comment.
I agree. I didn't meant to say this is in-scope for this PR.
But it'd be good to at least have an issue opened to track these things.
There was a problem hiding this comment.
I think it's good to have the discussion. I don't know if an extra issue is going to help given how much issues are open already.
There was a problem hiding this comment.
I'm not sure if people will find it if it's just here - I'd rather see it somewhere deep in the backlog, than just in our minds ;-)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)