ibus: fix dconf database #85992
Merged
ibus: fix dconf database #85992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Is bd6c12b#diff-a149871f918ec698c20b8b19f3f2e6d6 no longer necessary? |
|
Otherwise it still look reasonable to me at a glance but did not test it. |
Fixes this warning at ibus-daemon startup: (ibus-dconf:15691): dconf-WARNING **: 21:49:24.018: unable to open file '/etc/dconf/db/ibus': Failed to open file ?/etc/dconf/db/ibus?: open() failed: No such file or directory; expect degraded performance
This reverts commit ee5cba2.
|
Oh, indeed I lost some commits with git. I will fix this. |
|
This passes the ibus and xfce test, and I checked in a vm that ibus-daemon does not warn about dconf anymore. |
ofborg
bot
added
10.rebuild-linux: 11-100
and removed
10.rebuild-linux: 1
10.rebuild-linux: 1-10
labels
ttuegel
reviewed
Jun 24, 2020
Comment on lines
+14
to
+20
| concatStringsSep "\n" ( | ||
| mapAttrsToList ( | ||
| name: path: '' | ||
| ln -s ${path} $out/profile/${name} | ||
| '' | ||
| ) cfg.profiles | ||
| ) |
There was a problem hiding this comment.
Why won't the profiles already be linked by symlinkJoin?
There was a problem hiding this comment.
I was also confused by this but profiles are not packages, they are just file paths.
There was a problem hiding this comment.
yes, the symlinkJoin is only for the option packages and this loop is for the option profiles. So I think this is correct.
ttuegel
approved these changes
Jul 7, 2020
Comment on lines
+14
to
+20
| concatStringsSep "\n" ( | ||
| mapAttrsToList ( | ||
| name: path: '' | ||
| ln -s ${path} $out/profile/${name} | ||
| '' | ||
| ) cfg.profiles | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#85892 was reverted because of an evaluation error which manifested among other in xfce test.
This is a fixed PR where the xfce test evaluates.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)