Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] linux_5_5: throw a meaningful error instead of just removing the attribute #85990

Merged
merged 1 commit into from Apr 25, 2020
Merged

[20.03] linux_5_5: throw a meaningful error instead of just removing the attribute #85990

merged 1 commit into from Apr 25, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 25, 2020

Motivation for this change

I was using a 5.5 kernel on NixOS 20.03 and got an "attribute not found"
error yesterday when trying to update my system.

In order to understand why, I had to look up what happened in the git log which is IMHO not a good experience for e.g. a beginner.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
linux_5_5: throw a meaningful error instead of just removing the attr…
b938618 
…ibute

I was using a 5.5 kernel on NixOS 20.03 and got an "attribute not found"
error yesterday when trying to update my system.

In order to understand why, I had to look up what happened in the `git
log` which is IMHO not a good experience for e.g. a beginner.
@worldofpeace worldofpeace merged commit 1cdb903 into NixOS:release-20.03 Apr 25, 2020
@Ma27 Ma27 deleted the linux-5.5-eval-error branch April 25, 2020 15:22
@cole-h
Copy link
Member

cole-h commented Apr 25, 2020

Good idea, thanks :) I was in a rush to get borg evaluating again, so I did the quick and dirty change... I'll keep this in mind for the next time something like this happens (if there is one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@teto teto teto approved these changes

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@cole-h cole-h Awaiting requested review from cole-h

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ma27 @cole-h @Mic92 @teto @worldofpeace