[20.03] linux_5_5: throw a meaningful error instead of just removing the attribute #85990
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibute I was using a 5.5 kernel on NixOS 20.03 and got an "attribute not found" error yesterday when trying to update my system. In order to understand why, I had to look up what happened in the `git log` which is IMHO not a good experience for e.g. a beginner.
ofborg
bot
added
10.rebuild-darwin: 0
Mic92
approved these changes
Apr 25, 2020
teto
approved these changes
Apr 25, 2020
|
Good idea, thanks :) I was in a rush to get borg evaluating again, so I did the quick and dirty change... I'll keep this in mind for the next time something like this happens (if there is one). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I was using a 5.5 kernel on NixOS 20.03 and got an "attribute not found"
error yesterday when trying to update my system.
In order to understand why, I had to look up what happened in the
git logwhich is IMHO not a good experience for e.g. a beginner.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)