Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua51Packages.luaexpat: Removing broken meta attribute. #86071

Merged
merged 1 commit into from Apr 26, 2020
Merged

lua51Packages.luaexpat: Removing broken meta attribute. #86071

merged 1 commit into from Apr 26, 2020

Conversation

picnoir
Copy link
Member

@picnoir picnoir commented Apr 26, 2020 •
edited

Motivation for this change

Luaexpat has been mistakenly marked as broken during a
20.03 a zero hydra failures tree-wide commit. Removing the broken meta
attribute.

I discovered this problem when trying to rebuild the prosody XMPP server. Prosody itself is still green on Hydra. I assume marking an input as broken does not change the overall hash hence do not trigger a rebuild? Not sure...

I'm still not 100% sure why this was marked as broken, the build does not seem to be flaky. My current best assumption here is a tooling failure. I'm now wondering whether this same bug could happen somewhere else.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @worldofpeace

@picnoir
lua51Packages.luaexpat: Removing broken meta attribute.
5a31e46 
It seems like luaexpat as been mistakenly marked as broken during a
20.03 a zero hydra failures tree-wide commit. Removing the broken meta
attribute.

Discovered this problem when trying to rebuild the prosody XMPP server.
@worldofpeace worldofpeace changed the base branch from nixos-20.03 to release-20.03 April 26, 2020 18:44
@worldofpeace
Copy link
Contributor

Looks like it builds, perhaps it is just flaky.

@worldofpeace worldofpeace merged commit 9137f05 into NixOS:release-20.03 Apr 26, 2020
@picnoir picnoir deleted the luaexpat-remove-broken branch April 26, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@picnoir @worldofpeace