Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msmtp: 1.8.8 -> 1.8.10 #86027

Merged
merged 1 commit into from Apr 25, 2020
Merged

msmtp: 1.8.8 -> 1.8.10 #86027

merged 1 commit into from Apr 25, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Apr 25, 2020

This update contains the full fix for the unfortunate and very annoying
msmtpq regression 0. #YAY
This successfully reduces the amount of spam my setup generates :)
(Note: SCNR)

Relevant patches:

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
msmtp: 1.8.8 -> 1.8.10
6d7acff 
This update contains the full fix for the unfortunate and very annoying
msmtpq regression [0]. #YAY
This successfully reduces the amount of spam my setup generates :)
(Note: SCNR)

Relevant patches:
- marlam/msmtp@c78f243
- marlam/msmtp@dfb3959

[0]: https://marlam.de/msmtp/news/
@ofborg ofborg bot requested a review from peterhoeg April 25, 2020 23:03
@primeos primeos merged commit 4f17832 into NixOS:master Apr 25, 2020
@primeos
Copy link
Member Author

primeos commented Apr 25, 2020

It worked on my system and I decided to fast track this update as it's a bit urgent (depending on one's usage of msmtp).

 _        _______    _______  _______  _______  _______    _______  _______  _______  _______ 
( (    /|(  ___  )  (       )(  ___  )(  ____ )(  ____ \  (  ____ \(  ____ )(  ___  )(       )
|  \  ( || (   ) |  | () () || (   ) || (    )|| (    \/  | (    \/| (    )|| (   ) || () () |
|   \ | || |   | |  | || || || |   | || (____)|| (__      | (_____ | (____)|| (___) || || || |
| (\ \) || |   | |  | |(_)| || |   | ||     __)|  __)     (_____  )|  _____)|  ___  || |(_)| |
| | \   || |   | |  | |   | || |   | || (\ (   | (              ) || (      | (   ) || |   | |
| )  \  || (___) |  | )   ( || (___) || ) \ \__| (____/\  /\____) || )      | )   ( || )   ( |
|/    )_)(_______)  |/     \|(_______)|/   \__/(_______/  \_______)|/       |/     \||/     \|

(No offence intended)

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jun 5, 2020
@primeos @dtzWill
msmtp: 1.8.8 -> 1.8.10 (NixOS#86027)
8b5b10c 
This update contains the full fix for the unfortunate and very annoying
msmtpq regression [0]. #YAY
This successfully reduces the amount of spam my setup generates :)
(Note: SCNR)

Relevant patches:
- marlam/msmtp@c78f243
- marlam/msmtp@dfb3959

[0]: https://marlam.de/msmtp/news/

(cherry picked from commit 4f17832)
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jun 5, 2020
@dtzWill
Revert "msmtp: 1.8.8 -> 1.8.10 (NixOS#86027)"
2994e68 
This reverts commit 8b5b10c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos