Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor tweaks to develop on luaPackages.mpack #86075

Merged
merged 2 commits into from May 17, 2020
Merged

minor tweaks to develop on luaPackages.mpack #86075

merged 2 commits into from May 17, 2020

Conversation

teto
Copy link
Member

@teto teto commented Apr 26, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Repository was moved to an organization.
the luarocks package uses the builtin command and discards the Makefile.
While using the makefile one needs to set some more flags.
@teto
Copy link
Member Author

teto commented Apr 27, 2020

@GrahamcOfBorg build neovim-unwrapped

@teto teto merged commit 66c04a1 into NixOS:master May 17, 2020
@teto teto deleted the mpack branch September 5, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant