Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.bluepy: init at 1.3.0 #86064

Merged
merged 1 commit into from Apr 27, 2020
Merged

Conversation

georgewhewell
Copy link
Contributor

Motivation for this change

add bluepy package

closes #81330

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@georgewhewell
Copy link
Contributor Author

@jonringer thanks, applied

@jonringer
Copy link
Contributor

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the commits.

This can be done with:

git reset HEAD~2
git add -- pkgs/
git commit --amend --no-edit
git push ... ... --force

@georgewhewell
Copy link
Contributor Author

@jonringer rebased

@Mic92
Copy link
Member

Mic92 commented Apr 27, 2020

Result of nixpkgs-review pr 86064 1

3 packages built:
- python27Packages.bluepy
- python37Packages.bluepy
- python38Packages.bluepy

@Mic92 Mic92 merged commit c3b4c13 into NixOS:master Apr 27, 2020
@denibertovic
Copy link

@georgewhewell I'm trying to test this out. This is my shell.nix:

with import <nixpkgs> {};
# I copied the default.nix from this PR locally
(let bluepy = pkgs.python3Packages.callPackage ./default.nix;

in pkgs.python3.withPackages (ps: [bluepy]) ).env

when I run nix-shell and then try to import btle in the python repl it says module not found.
What am I doing wrong?

@denibertovic
Copy link

Nevermind. There were two issues. One is importing with "import btle" instead of "import bluepy". (I'm not sure why the bluepy docs have the wrong import listed). The other is that I had to pass buildPythonPackage = python35Packages.buildPythonPackage; to the callPackage call. Which is weird since I'm calling the callPackage from python3Packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to package bluepy
4 participants