Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awsweeper: 0.6.0 -> 0.7.0 #86014

Merged
merged 1 commit into from Apr 25, 2020
Merged

awsweeper: 0.6.0 -> 0.7.0 #86014

merged 1 commit into from Apr 25, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 25, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
Copy link
Member

cole-h commented Apr 25, 2020

@ofborg eval

Maybe if I ask GitHub really nicely, they'll stop breaking things.

@ofborg ofborg bot requested a review from kalbasit April 25, 2020 18:49
amanjeev
amanjeev approved these changes Apr 25, 2020
View reviewed changes
Copy link
Contributor

@amanjeev amanjeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package build on nixos 20.03
  • executables tested on 20.03
  • all depending packages build
Comments

Followed https://hydra.nixos.org/build/117063139/download/1/nixpkgs/manual.html#chap-reviewing-contributions

$ awsweeper --help

Usage: awsweeper [options] <config.yaml>

Delete AWS resources via a yaml configuration.

Options:
  --profile                             Use a specific profile from your credential file

  --region                              The region to use. Overrides config/env settings

  --dry-run                             Don't delete anything, just show what would happen

  --debug                               Enable debug logging

  --force                               Start deleting without asking for confirmation

  --timeout                     Amount of time to wait for a delete of a resource to finish

  --output                              The type of output result (string, json or yaml) default: string

@bhipple
Copy link
Contributor

bhipple commented Apr 25, 2020

Result of nixpkgs-review pr 86014 1

1 package built:
- awsweeper

@bhipple bhipple merged commit e005a48 into NixOS:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanjeev amanjeev amanjeev approved these changes

@bhipple bhipple bhipple approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @cole-h @bhipple @amanjeev