Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

claws-mail: add the litehtml_viewer plugin #86030

Merged
merged 1 commit into from Oct 2, 2020
Merged

claws-mail: add the litehtml_viewer plugin #86030

merged 1 commit into from Oct 2, 2020

Conversation

khumba
Copy link
Contributor

@khumba khumba commented Apr 26, 2020

Motivation for this change

The Claws Mail fancy (webkit) plugin has been deprecated for security reasons, but there's a new litehtml-based HTML viewer plugin to take its place (as of Claws 3.17.4). This PR adds support for that plugin. All that's needed is the addition of the gumbo HTML parser (dependency of litehtml). The Claws release tarball includes a copy of litehtml, for better or for worse; litehtml isn't in Nixpkgs yet but maybe we should package it ourselves and de-embed Claws's copy.

I've tested this out myself and it renders HTML emails fine for me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • The closure size for claws-mail goes from 1222376408 bytes to 1223641328 bytes (+1.21MiB).
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin and fpletz April 26, 2020 00:24
@ajs124
Copy link
Member

ajs124 commented May 15, 2020

Builds, loads and works for me. It doesn't render some things quite right, but that's an upstream issue.

@khumba
Copy link
Contributor Author

khumba commented Aug 3, 2020

Ping, it would be really great if this could get merged for 20.09 so that Claws could have an HTML renderer again, since the Webkit one was dropped.

@oxzi
Copy link
Member

oxzi commented Aug 21, 2020

I think it would be better to disable enablePluginLitehtmlViewer by default. If users want to use this plugin, they can just overwrite this option. Otherwise it looks good on first sight.

@khumba
Copy link
Contributor Author

khumba commented Aug 23, 2020

I think it would be better to disable enablePluginLitehtmlViewer by default. If users want to use this plugin, they can just overwrite this option. Otherwise it looks good on first sight.

Fine by me, changed.

@ajs124 ajs124 merged commit aa7f321 into NixOS:master Oct 2, 2020
@khumba khumba deleted the claws-litehtml branch January 3, 2021 15:13
@ajs124 ajs124 mentioned this pull request Mar 2, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 approved these changes

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khumba @ajs124 @oxzi