claws-mail: add the litehtml_viewer plugin #86030
Merged
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The Claws Mail fancy (webkit) plugin has been deprecated for security reasons, but there's a new litehtml-based HTML viewer plugin to take its place (as of Claws 3.17.4). This PR adds support for that plugin. All that's needed is the addition of the gumbo HTML parser (dependency of litehtml). The Claws release tarball includes a copy of litehtml, for better or for worse; litehtml isn't in Nixpkgs yet but maybe we should package it ourselves and de-embed Claws's copy.
I've tested this out myself and it renders HTML emails fine for me.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)