Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't protest on a non-ASCII path if the DLL can be loaded #2554

Merged
merged 1 commit into from
May 3, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented May 3, 2020

An afterthought on #2549.

" contains the non-ASCII character " + c +
"; this is known to confuse Mono.";
non_ascii_path_error = Directory.GetCurrentDirectory() +
" contains the non-ASCII character " + c +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message will look weird if c is a combining mark, and will be invalid if it is a surrogate.
Use https://docs.microsoft.com/en-gb/dotnet/api/system.globalization.stringinfo.gettextelementenumerator to iterate over the extended grapheme clusters of Directory.GetCurrentDirectory(), then look for a code unit above 127 within each cluster.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label May 3, 2020
@pleroy pleroy merged commit 755f3ec into mockingbirdnest:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants