bashtop: init at 0.8.23 #86673
bashtop: init at 0.8.23 #86673
Conversation
| sha256 = "0y6yxm2vmbz0373cfdl6mjh8vhs0r0wcng82n304klx90qxg3ljp"; | ||
| }; | ||
|
|
||
| buildInputs = [ bash_5 curl lm_sensors procps-ng sysstat ]; |
There was a problem hiding this comment.
| buildInputs = [ bash_5 curl lm_sensors procps-ng sysstat ]; | |
| buildInputs = [ bash_5 curl lm_sensors procps sysstat ]; |
Sorry, forgot to suggest this change, too.
There was a problem hiding this comment.
And I forgot to try building it. Thanks!
Fixups: - bashtop: use procps instead of procps-ng alias Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com>
There was a problem hiding this comment.
When I run this in a pure nix-shell (nix-shell -p bashtop --pure -I nixpkgs=.), the net and processes widgets don't work, nor does it detect the name of my CPU, and exiting leaves artifacts from the UI. Sorry I can't help much more than that, at the moment. Image of uncleared terminal attached below:
That said, in a normal nix-shell (like the one nixpkgs-review drops you into), it works perfectly. Probably impurities of my Arch+Nix system leaking through.
|
Works fine for me on NixOS. |
|
Can make a feature request for a .desktop launcher file? |
|
@ehmry Do you mean for upstream or as part of this PR? |
|
As part of the PR to make life easy for the Nix hostages. Just a suggestion, definitely not a blocker. |
There was a problem hiding this comment.
The buildInputs are not being carried over as runtime deps, which is the cause of the failure under a pure nix shell -- they're simply expected to (impurely) be present.
You can easily reproduce this from a nixpkgs-review shell by running nix-shell --pure. Then, try editing the nixpkgs-review shell.nix, manually adding the dependencies. Rerun the pure shell, and now it's working.
The paths to sed, ps, ... should either be patched in or the entire tool should be wrapped with a PATH that pulls in the deps.
|
Any update on this? |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
| install -Dm755 ${pname} $out/bin/${pname} | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
| meta = with stdenv.lib; { | |
| meta = with lib; { |
stale
bot
removed
the
2.status: stale
|
|
||
| dontBuild = true; | ||
| installPhase = '' | ||
| install -Dm755 ${pname} $out/bin/${pname} |
There was a problem hiding this comment.
With makeWrapper you can provide the runtime executable dependencies. You dont' have to add them to buildInputs, because that only has the effect of setting some environment variables during the build process; not at runtime.
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
Motivation for this change
https://github.com/aristocratos/bashtop/releases/tag/v0.8.23
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)