Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 19ff17d2196d
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 89c1a7ef912b
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on May 3, 2020

  1. Copy the full SHA
    23b7876 View commit details
  2. Merge pull request #2555 from pleroy/IHateMacOS

    std::filesystem doesn't seem to work on macOS
    pleroy authored May 3, 2020
    Copy the full SHA
    89c1a7e View commit details
Showing with 3 additions and 0 deletions.
  1. +3 −0 mathematica/mathematica_test.cpp
3 changes: 3 additions & 0 deletions mathematica/mathematica_test.cpp
Original file line number Diff line number Diff line change
@@ -357,6 +357,8 @@ TEST_F(MathematicaTest, ExpressIn) {
#endif
}

// std::filesystem is broken on macOS.
#if !defined(__APPLE__)
TEST_F(MathematicaTest, Logger) {
{
Logger logger(TEMP_DIR / "mathematica_test.wl", /*make_unique=*/true);
@@ -394,6 +396,7 @@ TEST_F(MathematicaTest, Logger) {
<< std::ifstream(TEMP_DIR / "mathematica_test0.wl").rdbuf())
.str());
}
#endif

} // namespace mathematica
} // namespace principia