Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Update to nix 2.3.4 #16

Merged
merged 1 commit into from May 6, 2020
Merged

Update to nix 2.3.4 #16

merged 1 commit into from May 6, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented May 3, 2020

This change also includes an addition of ARG instruction, so the installed nix version could be easily changed via docker build --build-arg NIX_VERSION=<version>

Supersedes #14

@domenkozar
Copy link
Member

@peti I'm not sure how you test Nix upgrades, but a simple nix-build -A git '<nixpkgs>' works with this commit and it would be good to merge this.

Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on the substance of the PR. 👎 on the seemingly arbitrary introduction of colons.

Dockerfile Outdated Show resolved Hide resolved
@peti
Copy link
Member

peti commented May 6, 2020

I'm not sure how you test Nix upgrades.

Travis-CI runs a test (and it's succeeding).

@peti peti self-assigned this May 6, 2020
This change also includes an addition of ARG instruction,
so the installed nix version could be easily changed via
docker build --build-arg NIX_VERSION=<version>
@domenkozar domenkozar requested a review from peti May 6, 2020 11:28
@peti peti merged commit d4965ab into NixOS:master May 6, 2020
@prusnak prusnak deleted the nix-2.3.4 branch May 6, 2020 14:10
@prusnak
Copy link
Member Author

prusnak commented May 6, 2020

Thanks peti for the merge and for pushing the updated container to Docker Hub!

Can we maybe also tag the container with 2.3.4 on Docker Hub?

@domenkozar
Copy link
Member

domenkozar commented May 6, 2020 via email

@peti
Copy link
Member

peti commented May 6, 2020

The tag now exists: https://hub.docker.com/repository/docker/nixos/nix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants