Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different packages with same name causes OpenTTD client to mess up #56

Closed
TrueBrain opened this issue May 3, 2020 · 4 comments
Closed
Assignees
Labels
bug Something isn't working prio: critical This issue is blocking people from using the system in a normal way

Comments

@TrueBrain
Copy link
Member

It is now possible to rename your package, and as such, people are renaming multiple packages of theirs to the same name.

I have no real problems with this, as the system considers the name a piece of metadata, but it turns out the OpenTTD client has a different vision on this.

When downloading a piece of content with the same name, it appears to be overwriting the existing file. This of course can be considered a bug on its own, but there is also not really a resolution for the client.

I want to suggest to rename the packages to <uniqueid>-<name>-<version>. This is still human-readable, and always unique.

@TrueBrain TrueBrain added bug Something isn't working prio: critical This issue is blocking people from using the system in a normal way labels May 3, 2020
@TrueBrain
Copy link
Member Author

Assigned you @frosch123 as I would like your opinion; not that you have to make the changes ;)

@frosch123
Copy link
Member

Looks good. OpenTTD already does something similar in openttd.cfg

[newgrf]
4F472B31|21377D78803A5BB9C57DE4C918A534B3|other/ogfx-trains.grf = 0 14 0 0 1

When unique-id/mdstum are specified, it uses them to look-up GRFs, and ignores the path. Useful when copying configs between machines or sharing profiles.

However, unless already the case, we should definitely enforce unique "version" within each package.

@TrueBrain
Copy link
Member Author

Versions have to be unique within a package, that is enforced :)

@frosch123
Copy link
Member

Fixed via
OpenTTD/bananas-server@a23a30e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio: critical This issue is blocking people from using the system in a normal way
Projects
None yet
Development

No branches or pull requests

2 participants