New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gspeech: init at 0.9.2 #86641
gspeech: init at 0.9.2 #86641
Conversation
0a6d4a0
to
24cfc21
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/creation-dun-paquet-nix-pour-gspeech/7039/1 |
chore: You may want to redo your |
29441d4
to
6a91f5a
Compare
correct, done. |
Trying to build locally (with sandboxing, on NixOS) fails with the following error: $ git clone https://github.com/mothsART/nixpkgs
$ git checkout feature/new-package-gspeech
$ nix build -I nixpkgs=./ nixpkgs.gspeech
builder for '/nix/store/z90zqbzd3b7g5hapbc5956rv4bh5rrdg-gSpeech-0.9.0.drv' failed with exit code 1; last 10 log lines:
writing entry points to gspeech.egg-info/entry_points.txt
writing top-level names to gspeech.egg-info/top_level.txt
package init file 'speech/workers/__init__.py' not found (or not a regular file)
package init file 'speech/workers/fr_FR/__init__.py' not found (or not a regular file)
reading manifest file 'gspeech.egg-info/SOURCES.txt'
writing manifest file 'gspeech.egg-info/SOURCES.txt'
running build_ext
/build/source/speech/widgets/save.py:5: PyGIWarning: Gtk was imported without specifying a version first. Use gi.require_version('Gtk', '3.0') before import to ensure that the right version gets loaded.
from gi.repository import Gtk
error: [Errno 13] Permission denied: '/homeless-shelter'
[1 built (1 failed), 174 copied (803.4 MiB), 178.9 MiB DL]
error: build of '/nix/store/z90zqbzd3b7g5hapbc5956rv4bh5rrdg-gSpeech-0.9.0.drv' failed I see ofborg has the exact same problem trying to build gspeech. Unfortunately, I'm not too familiar with building python packages in nix, so my helping is limited. This error: |
6a91f5a
to
10e9996
Compare
Found : I edited my project, pass to version 0.9.1 and updated my sha256 hash. |
Confirmed, I can now build the project on NixOS with sandboxing enabled. $ ./result/bin/gspeech
Traceback (most recent call last):
File "/nix/store/2521np3363z8vzk8358lb3mcpsb1pxka-gSpeech-0.9.1/bin/..gspeech-wrapped-wrapped", line 9, in <module>
sys.exit(main())
File "/nix/store/2521np3363z8vzk8358lb3mcpsb1pxka-gSpeech-0.9.1/lib/python3.7/site-packages/speech/main.py", line 249, in main
pid.kill_if_already_exist(conf.app_name, conf.pid)
File "/nix/store/2521np3363z8vzk8358lb3mcpsb1pxka-gSpeech-0.9.1/lib/python3.7/site-packages/speech/pid.py", line 23, in kill_if_already_exist
with open(pid_path, 'w') as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/eeva/.cache/gSpeech/gspeech.pid' |
The other binary seems to run fine though: $ ./result/bin/gspeech-cli
gSpeech version 0.9.0
Usage : gSpeech-cli -i "[text to read]" ( or -f [txt file] ) -o [.wav filename] ... -l [optional lang]
Common flags:
-h --help show usage information
-v --version show version information
-i --input-text text to read
-f --input-file file to read (supported only plain txt
-o --output-file name of the audio output file (wav type)
-l --lang language
possible languages:
de-DE
en-GB
en-US
es-ES
fr-FR
it-IT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, builds in sandbox, produces valid binaries
10e9996
to
56d8f73
Compare
No problems with runtime dependencies. An other application bug (on first launch) ; correction on 0.9.2 version. |
running
|
This works fine: |
You can use For instance:
This package is a fork of a fork of a fork. Is there a particular reason not to upstream your changes? Did you try to at least to open a PR upstream? |
56d8f73
to
f36cbdc
Compare
thanks to all: i use "wrapProgram" now and gspeech is working like a charm. @NinjaTrappeur : this package is a fork of a fork, i'm aware of it. Last at least one year, the creator of Gspeech redirect to the fork : https://github.com/tuxmouraille/gSpeech/issues/4#issuecomment-454307959 I've pushed 2 PR to lusum repo, merged by him after a long time but reworked behind without PEP8, an ugly monolitic code... My goal was to refactor for bring unit and fonctionnal test with CI, flake8 compatibility, add some algorithms and dictionnary to perform tts quality (french tts first), upgrade to python3 and gtk3, adapt for better debian and nix packaging etc. Doing all of this in upstream would have taken me a lot longer and a lot of uncertainty. |
hmm, running |
@Lassulus : gspeech launch an application indicator like this https://wiki.primtux.fr/lib/exe/detail.php/wiki:gspeech.png?id=gspeech |
ah, I didn't have a tray, tested it now with stalonetray, everything works fine |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)