Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor: fix cross compiling #86767

Merged
merged 1 commit into from May 9, 2020
Merged

tor: fix cross compiling #86767

merged 1 commit into from May 9, 2020

Conversation

sorki
Copy link
Member

@sorki sorki commented May 4, 2020

Motivation for this change

Otherwise the buildsystem throws an error about tool-chain incompatibility.

checking for armv7l-unknown-linux-gnueabihf-ar... armv7l-unknown-linux-gnueabihf-ar
checking the archiver (armv7l-unknown-linux-gnueabihf-ar) interface... ar
configure: error: We are cross compiling but could not find a properly named toolchain. Do you have your cross-compiling toolchain in PATH? (You can --disable-tool-name-check to ignore this.)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sorki sorki changed the title nixos/tor: fix cross compiling tor: fix cross compiling May 4, 2020
@sorki sorki added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label May 4, 2020
@sorki
Copy link
Member Author

sorki commented May 4, 2020

Pinging maintainers @Phreedom @doublec @thoughtpolice @joachifm

@joachifm joachifm merged commit 16e475d into NixOS:master May 9, 2020
@joachifm
Copy link
Contributor

joachifm commented May 9, 2020

Makes sense to pick this to the release branch as well, I think.

@sorki sorki mentioned this pull request May 9, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants