[20.03] haskellPackages.ghcide: Fix build #86659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maralorn
requested review from
basvandijk,
cdepillabout and
infinisil
as code owners
maralorn
changed the title
cdepillabout
reviewed
May 4, 2020
cdepillabout
reviewed
May 4, 2020
|
@maralorn Thanks for working on this. I think a lot of Haskellers have been trying out ghcide. It'd be nice if people could just get it from nixpkgs. |
|
@cdepillabout I do believe I have now fixed all your concerns and all my concerns.
|
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
cdepillabout
reviewed
May 4, 2020
10 tasks
|
One more change and this can be merged in:
Once that is done, I will merge this in. I have confirmed that |
cdepillabout
reviewed
May 4, 2020
maralorn
added a commit
to maralorn/nixpkgs
that referenced
this pull request
May 4, 2020
This is the haskell-updates version of NixOS#86659
peti
pushed a commit
that referenced
this pull request
May 5, 2020
This is the haskell-updates version of #86659
peti
pushed a commit
that referenced
this pull request
May 8, 2020
This is the haskell-updates version of #86659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ghcideis marked as broken and is not building. With these changes it builds.Please let me know if I should structure the overrides in a different way.
When this PR is approved I will port it to the haskell-updates branch. But first I wanna know if I did this right.
I am especially confused by the recursive library overrides. It‘s not pretty this way. e.g. the override for regex-tdfa_1_3_1_0 which needs a pinned regex-base version is now twice in the file.
Things done
sandboxinnix.confon non-NixOS linux)./result/bin/)