Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoxide: 0.3.1 -> 0.4.0 #86658

Merged
merged 1 commit into from May 3, 2020
Merged

zoxide: 0.3.1 -> 0.4.0 #86658

merged 1 commit into from May 3, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented May 3, 2020

ajeetdsouza/zoxide@v0.3.1...v0.4.0

Most notable changes, IMHO:

  • zoxide init now uses PWD hooks by default
  • fish no longer cds to the user's home when no match is found
  • Interactive mode in zoxide no longer throws an error if fzf exits gracefully
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
zoxide: 0.3.1 -> 0.4.0
fb7e28e 
ajeetdsouza/zoxide@v0.3.1...v0.4.0

Most notable changes, IMHO:

- `zoxide init` now uses PWD hooks by default
- `fish` no longer `cd`s to the user's home when no match is found
- Interactive mode in `zoxide` no longer throws an error if `fzf` exits gracefully
@ofborg ofborg bot requested a review from ysndr May 3, 2020 15:10
@dywedir
Copy link
Member

dywedir commented May 3, 2020

Thanks!

@dywedir dywedir merged commit e09bdc1 into NixOS:master May 3, 2020
@cole-h cole-h deleted the zoxide branch May 3, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@ysndr ysndr Awaiting requested review from ysndr

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cole-h @dywedir @prusnak