nodePackages: init he and escape-string-regexp #86773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rework your PR. It now has a merge conflict after PR #89184 has been merged |
|
@prusnak I have rebased on master. |
prusnak
requested changes
May 31, 2020
| buildInputs = globalBuildInputs; | ||
| meta = { | ||
| description = "A robust HTML entities encoder/decoder with full Unicode support."; | ||
| homepage = https://mths.be/he; |
There was a problem hiding this comment.
Does this come from node2nix? As per RFC45 the URLs should be quoted:
Suggested change
| homepage = https://mths.be/he; | |
| homepage = "https://mths.be/he"; |
prusnak
approved these changes
Jun 1, 2020
|
Is it possible to get this merged, please? |
|
Thanks!
…On Thu, Jun 11, 2020, 8:19 AM Dmitry Kalinkin ***@***.***> wrote:
Landed as 74ff4f6
<74ff4f6>
and d6c0115
<d6c0115>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#86773 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRJXGGNKKMVAFMLTJNSJLRWAPHNANCNFSM4MYXXJOA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a prerequisite for building the Vulkan
documentation. Vulkan-Docs
doesn't come with a well-formed package.json which makes it difficult to
use with node2nix or other tools. Having these packages here makes it
very easy.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)