Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluez: add configuration options to package #86677

Closed
wants to merge 1 commit into from
Closed

bluez: add configuration options to package #86677

wants to merge 1 commit into from

Conversation

btlvr
Copy link
Contributor

@btlvr btlvr commented May 3, 2020

Motivation for this change

I wanted to be able to enable the deprecated tools

Things done

Added configuration options to the bluez package

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • ? Fits CONTRIBUTING.md.

doronbehar
doronbehar requested changes May 4, 2020
View reviewed changes
pkgs/os-specific/linux/bluez/default.nix
};
}
let
configEnableFlag = flag : ( enabled : if enabled then "--enable-" + flag else "" );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://nixos.org/nixpkgs/manual/#function-library-lib.strings.enableFeature .

@wucke13 wucke13 mentioned this pull request Mar 14, 2021
Closed
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@doronbehar
Copy link
Contributor

Closing as OP does not respond.

@doronbehar doronbehar closed this Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@btlvr @doronbehar @ryantm