Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/picom: cleanup #86678

Merged
merged 2 commits into from May 6, 2020
Merged

nixos/picom: cleanup #86678

merged 2 commits into from May 6, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented May 3, 2020

Motivation for this change

Fix the ugly type in #86402 and clean up the module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested Picom with various configuration in a VM
  • Built manual
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

- Use floating points instead of strings, which Nix now supports

- Make the type of picom.settings option recursive

- Add a meaningful description of both the option and its type
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine for me

@rnhmjoj rnhmjoj merged commit dc9c88a into NixOS:master May 6, 2020
@rnhmjoj rnhmjoj deleted the picom branch June 19, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants